|
From: | Paul Eggert |
Subject: | Re: [PATCH] snprintf: port snprintf (NULL, 0, ...) to Solaris 8 and 9 |
Date: | Wed, 22 Dec 2010 15:25:59 -0800 |
User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101208 Thunderbird/3.1.7 |
On 12/22/10 13:57, Bruno Haible wrote: > But I would find it good if > > - you would modify m4/vsnprintf.m4 like m4/snprintf.m4 - otherwise the > gnulib modules 'vsnprintf' and 'snprintf' are inconsistent. > > - the files doc/posix-functions/{snprintf,vsnprintf}.texi were be > updated to match the code. > > - the test suite would be updated accordingly, i.e. the tests for the > correct return value were moved from tests/test-snprintf-posix.h to > tests/test-snprintf.c and tests/test-vsnprintf.c. Thanks for the review and these are all good suggestions; I'll look into them.
[Prev in Thread] | Current Thread | [Next in Thread] |