bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] ftoastr, snprintf: ftoastr + snprintf module


From: Paul Eggert
Subject: [PATCH] ftoastr, snprintf: ftoastr + snprintf module
Date: Wed, 29 Dec 2010 01:27:43 -0800
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101208 Thunderbird/3.1.7

* lib/ftoastr.c: Use GNULIB_SNPRINTF, not GNULIB_SNPRINTF_POSIX,
since the snprintf module now should be good enough here.
* modules/snprintf (configure.ac): Add gl_MODULE_INDICATOR([snprintf]).
It seems odd to have both gl_STDIO_MODULE_INDICATOR([snprintf])
and gl_MODULE_INDICATOR([snprintf]), but the former enables
GNULIB_SNPRINTF only for the test directory, and the latter
doesn't arrange for gl_STDIO_H_DEFAULTS to be called, so neither
seems to suffice by itself.
---
 ChangeLog        |   12 ++++++++++++
 lib/ftoastr.c    |    2 +-
 modules/snprintf |    1 +
 3 files changed, 14 insertions(+), 1 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 5c95bc4..021102c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,15 @@
+2010-12-29  Paul Eggert  <address@hidden>
+
+       ftoastr, snprintf: ftoastr + snprintf module
+       * lib/ftoastr.c: Use GNULIB_SNPRINTF, not GNULIB_SNPRINTF_POSIX,
+       since the snprintf module now should be good enough here.
+       * modules/snprintf (configure.ac): Add gl_MODULE_INDICATOR([snprintf]).
+       It seems odd to have both gl_STDIO_MODULE_INDICATOR([snprintf])
+       and gl_MODULE_INDICATOR([snprintf]), but the former enables
+       GNULIB_SNPRINTF only for the test directory, and the latter
+       doesn't arrange for gl_STDIO_H_DEFAULTS to be called, so neither
+       seems to suffice by itself.
+
 2010-12-28  Paul Eggert  <address@hidden>
 
        alloca: one step towards thread-safety
diff --git a/lib/ftoastr.c b/lib/ftoastr.c
index a55b24e..49f721b 100644
--- a/lib/ftoastr.c
+++ b/lib/ftoastr.c
@@ -69,7 +69,7 @@
 /* On hosts where it's not known that snprintf works, use sprintf to
    implement the subset needed here.  Typically BUFSIZE is big enough
    and there's little or no performance hit.  */
-#if ! GNULIB_SNPRINTF_POSIX
+#if ! GNULIB_SNPRINTF
 # undef snprintf
 # define snprintf ftoastr_snprintf
 static int
diff --git a/modules/snprintf b/modules/snprintf
index 27c343e..e8b5dfb 100644
--- a/modules/snprintf
+++ b/modules/snprintf
@@ -14,6 +14,7 @@ errno
 configure.ac:
 gl_FUNC_SNPRINTF
 gl_STDIO_MODULE_INDICATOR([snprintf])
+gl_MODULE_INDICATOR([snprintf])
 
 Makefile.am:
 
-- 
1.7.2




reply via email to

[Prev in Thread] Current Thread [Next in Thread]