bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] nl_langinfo: fix YESEXPR on Irix 6.5


From: Eric Blake
Subject: Re: [PATCH] nl_langinfo: fix YESEXPR on Irix 6.5
Date: Fri, 31 Dec 2010 16:24:06 -0700
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.7

On 12/31/2010 02:15 PM, Bruno Haible wrote:

Hi Bruno, and thanks for the review;

> 
>> +         case "$host_os" in
>> +                          # Guess no on irix systems.
>> +           *-irix*)       gl_cv_func_nl_langinfo_yesexpr_works="guessing 
>> no";;
> 
> Here replace   *-irix*   with   irix*
> since you are testing "$host_os", not "$host".

Indeed.

> 
>> +    if test $HAVE_LANGINFO_CODESET = 1 && test $HAVE_LANGINFO_ERA = 1 \
>> +      && test $FUNC_NL_LANGINFO_YESEXPR_WORKS = 1; then
>>        :
> 
> Here add one more space of indentation before &&, please.
> 
>> I guess I should also update docs/posix-functions/nl_langinfo.texi.
> 
> Yes, please.

Done, and pushed.

-- 
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]