[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Openat without die
From: |
Bruno Haible |
Subject: |
Re: Openat without die |
Date: |
Tue, 11 Jan 2011 17:07:59 +0100 |
User-agent: |
KMail/1.9.9 |
Bastien,
> BTW do you agree with merging my fist two patch?
This question is to be answered by Jim and Eric, since the 'openat' module
is theirs.
I can only give you hints what I would improve before resubmitting the patches:
- The first patch is incomplete: it provokes a NULL pointer access in
sprintf(), which is fixed in the second patch. Please always split patches
in such a way that each part is correct on its own, or - if you can't do
that - please combine them.
- GNU coding style: Put a space after 'if': "if (...)".
- Redundant blank lines: After the main #include statement, we have the
habit of listing all #include <> in a row, then a blank line, then all
#include "" in a row.
- The comment "use system definition of malloc here allocation is alway > 1"
can be improved in three ways: grammar or comma placement, spelling,
and write 0 not 1 (since rpl_malloc(1) and malloc(1) are equivalent).
Bruno
- Re: Openat without die, (continued)
- Re: Openat without die, Eric Blake, 2011/01/11
- Re: Openat without die, Jim Meyering, 2011/01/11
- Re: Openat without die, Paul Eggert, 2011/01/11
- Re: Openat without die, Jim Meyering, 2011/01/11
- Re: Openat without die, Paul Eggert, 2011/01/11
- Re: Openat without die, Jim Meyering, 2011/01/11
- Re: Openat without die, Jim Meyering, 2011/01/11
- Message not available
- ChangeLog fix for openat-die fix, Paul Eggert, 2011/01/12
- Re: Openat without die, Bastien ROUCARIES, 2011/01/12
- Re: Openat without die, Eric Blake, 2011/01/12
- Re: Openat without die,
Bruno Haible <=
- Re: Openat without die, Jim Meyering, 2011/01/13
Re: Openat without die, Jim Meyering, 2011/01/11