Re: Openat without die

[Bruno Haible]

Bastien,

> BTW do you agree with merging my fist two patch?

This question is to be answered by Jim and Eric, since the 'openat' module
is theirs.

I can only give you hints what I would improve before resubmitting the patches:
  - The first patch is incomplete: it provokes a NULL pointer access in
    sprintf(), which is fixed in the second patch. Please always split patches
    in such a way that each part is correct on its own, or - if you can't do
    that - please combine them.
  - GNU coding style: Put a space after 'if': "if (...)".
  - Redundant blank lines: After the main #include statement, we have the
    habit of listing all #include <> in a row, then a blank line, then all
    #include "" in a row.
  - The comment "use system definition of malloc here allocation is alway > 1"
    can be improved in three ways: grammar or comma placement, spelling,
    and write 0 not 1 (since rpl_malloc(1) and malloc(1) are equivalent).

Bruno