[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] bootstrap: support --no-git option
From: |
Eric Blake |
Subject: |
Re: [PATCH] bootstrap: support --no-git option |
Date: |
Fri, 21 Jan 2011 09:08:52 -0700 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.7 |
On 01/20/2011 11:54 AM, Eric Blake wrote:
> From: Benjamin Lindner <address@hidden>
>
> * build-aux/bootstrap: Add --no-git option, to be used when
> --gnulib-srcdir points to the exact desired checkout.
>
> Signed-off-by: Eric Blake <address@hidden>
> ---
>
> I'd like to push this in your name, once I have your okay. The
> (tiny change) notation reflects your copyright status, and is
> not demeaning the work you put into this.
> + --no-git Do not update gnulib using git. Requires that
> + --gnulib-srcdir points to a complete gnulib source
> + tree
I'm tweaking this (two spaces after ., trailing . to match other options
[although that's debatable, it would take a separate patch to clean up
the usage for all options], sorting before --skip-po, and more concise):
> --no-git Do not use git to update gnulib. Requires that
> --gnulib-srcdir point to a correct gnulib snapshot.
> + echo "Error: --no-git requires --gnulib-srcdir" >&2
Needs $0 in the message.
> @@ -384,6 +400,10 @@ check_versions() {
> if test "$app" = libtool; then
> app=libtoolize
> fi
> + # only test for git if not using --no-git
And that comment was a double-negative, rewritten as:
> # Exempt git if --no-git is in effect.
I went ahead and pushed this, since libvirt (at least) is clamoring to
have it sooner rather than later.
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- gnulib unnecessarily enforces git as requirement, Benjamin Lindner, 2011/01/20
- Re: gnulib unnecessarily enforces git as requirement, Eric Blake, 2011/01/20
- Re: gnulib unnecessarily enforces git as requirement, Benjamin Lindner, 2011/01/20
- Re: gnulib unnecessarily enforces git as requirement, Eric Blake, 2011/01/20
- Re: gnulib unnecessarily enforces git as requirement, Benjamin Lindner, 2011/01/20
- Re: gnulib unnecessarily enforces git as requirement, Eric Blake, 2011/01/20
- [PATCH] bootstrap: support --no-git option, Eric Blake, 2011/01/20
- Re: [PATCH] bootstrap: support --no-git option, Eric Blake, 2011/01/20
- Re: [PATCH] bootstrap: support --no-git option,
Eric Blake <=
- Re: [PATCH] bootstrap: support --no-git option, Benjamin Lindner, 2011/01/25
- Re: gnulib unnecessarily enforces git as requirement, Benjamin Lindner, 2011/01/25
Re: gnulib unnecessarily enforces git as requirement, Jim Meyering, 2011/01/20