Re: ignore-value vs off_t

[Eric Blake]

On 01/31/2011 07:50 AM, Eric Blake wrote:
> On 01/30/2011 01:29 AM, Simon Josefsson wrote:
>> Looks like the off_t definition is not getting pulled in by
>> test-ignore-value.c?  I pushed the patch below.
> 
> <stdio.h> is required to provide off_t, at least, when POSIX is in
> effect.  Which platform did you encounter the failure on, and was our
> replacement <stdio.h> in effect, or is this a missing test dependency on
> the extensions module?

I'm pushing this:

diff --git c/ChangeLog w/ChangeLog
index 54c2e90..6ab5e34 100644
--- c/ChangeLog
+++ w/ChangeLog
@@ -1,3 +1,10 @@
+2011-01-31  Eric Blake  <address@hidden>
+
+       ignore-value: add missing test dependency
+       * tests/test-ignore-value.c: Revert previous change; stdio.h
+       provides off_t.
+       * modules/ignore-value-tests (Depends-on): Add missing dependency.
+
 2011-01-30  Paul Eggert  <address@hidden>

        mktime: clarify long_int width checking
diff --git c/modules/ignore-value-tests w/modules/ignore-value-tests
index e79478f..9c8c6d6 100644
--- c/modules/ignore-value-tests
+++ w/modules/ignore-value-tests
@@ -2,6 +2,7 @@ Files:
 tests/test-ignore-value.c

 Depends-on:
+stdio

 configure.ac:

diff --git c/tests/test-ignore-value.c w/tests/test-ignore-value.c
index c21d5be..a1c86e0 100644
--- c/tests/test-ignore-value.c
+++ w/tests/test-ignore-value.c
@@ -22,7 +22,6 @@
 #include "ignore-value.h"

 #include <stdio.h>
-#include <sys/types.h>

 #ifndef ATTRIBUTE_RETURN_CHECK
 # if __GNUC__ < 3 || (__GNUC__ == 3 && __GNUC_MINOR__ < 1)


-- 
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature