Re: [PATCH] libposix: Add _HEADERS primaries to posix modules.

[Eric Blake]

On 02/05/2011 09:15 AM, Bruce Korb wrote:
> Hi Bruno, et al.  I have merged the patch:
> http://lists.gnu.org/archive/html/bug-gnulib/2011-02/msg00044.html
> into the sources, yielding the patch below.  Barring final testing
> problems or complaints, I am hoping to push later today.
> Thank you.  Regards, Bruce

This patch broke projects, yet it has no mention in NEWS how to fix
things.  For example, upgrading m4.git to use the latest gnulib results in:

$ make check
CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/sh
/home/remote/eblake/m4-branch/build-aux/missing --run aclocal-1.11 -I m4
 cd . && /bin/sh /home/remote/eblake/m4-branch/build-aux/missing --run
automake-1.11 --gnu
lib/gnulib.mk:25: nodist_pkginclude_HEADERS must be set with `=' before
using `+='
lib/Makefile.am:29:   `lib/gnulib.mk' included from here
lib/gnulib.mk:26: EXTRA_HEADERS must be set with `=' before using `+='
lib/Makefile.am:29:   `lib/gnulib.mk' included from here
lib/gnulib.mk:1883: nobase_nodist_pkginclude_HEADERS must be set with
`=' before using `+='
lib/Makefile.am:29:   `lib/gnulib.mk' included from here
make: *** [Makefile.in] Error 1

Also, your commit had LOTS of edits to ChangeLog, but only a single
commit.  I would much rather have one commit per ChangeLog entry than
have a merged conglomerate like this patch; it makes bisection much
easier to figure out why your commit broke things.  I'm not sure whether
we would make a one-time exception to the no-merge-on-master hook, or
whether you should just rebase your branch onto master to preserve the
individual commits.

I have half a mind to revert your patch, and leave things on just the
topic/libposix branch, until you can prove that your commit will be safe
or document in NEWS how to cope with your commit.

-- 
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature