bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] maint: adjust cpp indentation for my modules, as well


From: Jim Meyering
Subject: Re: [PATCH] maint: adjust cpp indentation for my modules, as well
Date: Tue, 22 Feb 2011 16:57:09 +0100

Eric Blake wrote:
...
> Not too many of mine, either.  By the way, did you intend
> that sc_cpp_indent_check was not run by 'make check'?

No.  I forgot that just adding an sc_ name here does not
automatically do what I want (like it does in maint.mk).
This Makefile is so specialized that I think it can assume GNU make.
Does anyone prefer not to do that?
Then we wouldn't have to maintain the separate list of sc_* targets.

I've just made this additional change.

BTW, I omitted getloadavg.c since it had so many violations
and is soooo crufty, and since Paul just got it into emacs.
However, considering the number of cpp conditionals, it might
benefit from the conversion.  Paul, what do you think?
Either way is fine with me.


>From 7e1bc3bdd19e270d6672160ed1b90b9e176292e6 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Tue, 22 Feb 2011 16:51:29 +0100
Subject: [PATCH] maint: sc_cpp_indent_check: remove the "only in lib/" 
restriction

* Makefile (sc_cpp_indent_check): Don't limit the check to files
in lib/.
---
 ChangeLog |    6 ++++++
 Makefile  |    4 ++--
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index ca6bb93..ee86ca9 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2011-02-22  Jim Meyering  <address@hidden>
+
+       maint: sc_cpp_indent_check: remove the "only in lib/" restriction
+       * Makefile (sc_cpp_indent_check): Don't limit the check to files
+       in lib/.
+
 2011-02-22  Eric Blake  <address@hidden>

        maint: avoid any CDPATH issue
diff --git a/Makefile b/Makefile
index 776de73..9c0d0c3 100644
--- a/Makefile
+++ b/Makefile
@@ -46,12 +46,12 @@ sc_pragma_columns:
        else :; fi

 # Verify that certain (for now, only Jim Meyering and Eric Blake's)
-# lib/**.c files are consistently cpp indented.
+# *.c files are consistently cpp indented.
 sc_cpp_indent_check:
        ./gnulib-tool --extract-filelist \
             $$(cd ./modules; grep -ilrE '(meyering|blake)' .) \
           | sort -u \
-          | grep 'lib/.*\.c$$' \
+          | grep '\.c$$' \
           | grep -v '/getloadavg\.c$$' \
           | xargs cppi -c

--
1.7.4.1.16.g759e8



reply via email to

[Prev in Thread] Current Thread [Next in Thread]