Re: regex-quote.c syntax support

[Reuben Thomas]

On 6 March 2011 13:51, Reuben Thomas <address@hidden> wrote:
> On 6 March 2011 13:41, Bruno Haible <address@hidden> wrote:
>>
>>> RE_NO_BK_REFS -> [:digit:]
>>
>> I don't know what you mean by that? '[' and ']' are already in the list of
>> characters to be escaped. So no need to look at RE_NO_BK_REFS, right?
>
> I'm not sure what it has to do with '[' and ']', but indeed if the
> input (literal) string contains "\[:digit:]" then it's always safe to
> escape the backslash, sorry.
>
> Thanks very much for the new API; I'll comment when I've had a chance
> to read it.

I like the balance between having a documented "quote task" data
structure that can be constructed manually, while having constructor
functions for the POSIX, PCRE and GNU cases, so as to make casual use
risk-free.

The only thing I find confusing is the "multibyte" flag, which is zero
for UTF-8 text (which is a multibyte format). Did you really mean
"wide character" rather than "multibyte"?

-- 
http://rrt.sc3d.org