[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] maint.mk: suppress a syntax check false positive
From: |
Jim Meyering |
Subject: |
Re: [PATCH] maint.mk: suppress a syntax check false positive |
Date: |
Fri, 11 Mar 2011 10:32:40 +0100 |
Pádraig Brady wrote:
> A recent change to dd in coreutils triggered this issue,
> which is avoided with the attached.
Thanks!
I've pushed that.
> + maint.mk: suppress a false positive warning
> + * top/maint.mk ((sc_unmarked_diagnostics): Don't warn when
> + diagnostics are marked with ngettext.
...
> diff --git a/top/maint.mk b/top/maint.mk
...
> sc_unmarked_diagnostics:
> @grep -nE \
> '\<error *\([^"]*"[^"]*[a-z]{3}' $$($(VC_LIST_EXCEPT)) \
> - | grep -v '_''(' && \
> + | grep -Ev '(_|ngettext )\(' && \
Then wondered if we should be more permissive in what we filter out,
perhaps by allowing 0 or more spaces between ngettext and the following "(":
| grep -Ev '(_|ngettext *)\(' && \
It's probably not worth anchoring the left side of "ngettext"
to a word boundary.