bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] maint.mk: suppress a syntax check false positive


From: Pádraig Brady
Subject: Re: [PATCH] maint.mk: suppress a syntax check false positive
Date: Fri, 11 Mar 2011 13:56:30 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3

On 11/03/11 13:50, Eric Blake wrote:
> On 03/11/2011 02:32 AM, Jim Meyering wrote:
>> Pádraig Brady wrote:
>>> A recent change to dd in coreutils triggered this issue,
>>> which is avoided with the attached.
>>
>>>  sc_unmarked_diagnostics:
>>>     @grep -nE                                                       \
>>>         '\<error *\([^"]*"[^"]*[a-z]{3}' $$($(VC_LIST_EXCEPT))      \
>>> -     | grep -v '_''(' &&                                           \
>>> +     | grep -Ev '(_|ngettext )\(' &&                               \
> 
> Don't we recommend the use of N_() rather than spelling out ngettext ()?

N_ usually means, mark for translate; but don't use this position.
ngettext is for choosing a plural form.

> 
>>
>> Then wondered if we should be more permissive in what we filter out,
>> perhaps by allowing 0 or more spaces between ngettext and the following "(":
>>
>>        | grep -Ev '(_|ngettext *)\(' &&                              \
> 
> If we're going to look for raw ngettext, why not also look for raw
> gettext, or even d?c?n?gettext?

I guess we should support dgettext and dcgettext too.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]