[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] maint.mk: let po check work in VPATH build
From: |
Bruno Haible |
Subject: |
Re: [PATCH] maint.mk: let po check work in VPATH build |
Date: |
Sat, 19 Mar 2011 13:18:43 +0100 |
User-agent: |
KMail/1.9.9 |
Eric Blake wrote:
> >> + for file in $$($(VC_LIST_EXCEPT)) $(srcdir)lib/*.[ch]; do \
> >
> > Is $(srcdir) expected to end in a slash or not?
>
> Not. Autoconf intentionally strips any trailing slash given by the
> user. Thanks for the catch (the idea of $(srcdir)/lib/*.[ch]
Then, I think, wouldn't this patch be appropriate?
--- top/maint.mk.orig Sat Mar 19 13:17:10 2011
+++ top/maint.mk Sat Mar 19 13:16:44 2011
@@ -961,7 +961,7 @@
grep -E -v '^(#|$$)' $(po_file) \
| grep -v '^src/false\.c$$' | sort > address@hidden;
\
files=; \
- for file in $$($(VC_LIST_EXCEPT)) $(srcdir)lib/*.[ch]; do \
+ for file in $$($(VC_LIST_EXCEPT)) $(srcdir)/lib/*.[ch]; do \
test -r $$file || continue; \
case $$file in \
*.m4|*.mk) continue ;; \
--
In memoriam Fred Scamaroni <http://fr.wikipedia.org/wiki/Fred_Scamaroni>