Re: [PATCH] maint.mk: let po check work in VPATH build

[Jim Meyering]

Bruno Haible wrote:
> Eric Blake wrote:
>> >> +   for file in $$($(VC_LIST_EXCEPT)) $(srcdir)lib/*.[ch]; do     \
>> >
>> > Is $(srcdir) expected to end in a slash or not?
>>
>> Not.  Autoconf intentionally strips any trailing slash given by the
>> user.  Thanks for the catch (the idea of $(srcdir)/lib/*.[ch]
>
> Then, I think, wouldn't this patch be appropriate?
>
>
> --- top/maint.mk.orig Sat Mar 19 13:17:10 2011
> +++ top/maint.mk      Sat Mar 19 13:16:44 2011
> @@ -961,7 +961,7 @@
>         grep -E -v '^(#|$$)' $(po_file)                               \
>           | grep -v '^src/false\.c$$' | sort > address@hidden;                
>         \
>         files=;                                                       \
> -       for file in $$($(VC_LIST_EXCEPT)) $(srcdir)lib/*.[ch]; do     \
> +       for file in $$($(VC_LIST_EXCEPT)) $(srcdir)/lib/*.[ch]; do    \
>           test -r $$file || continue;                                 \
>           case $$file in                                              \
>             *.m4|*.mk) continue ;;                                    \

I've pushed this:

>From 739321ef60661c7b51a4c7a3fa23957a4d9dbbc3 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Sat, 19 Mar 2011 18:21:56 +0100
Subject: [PATCH] maint.mk: fix po-file syntax-check rule

* top/maint.mk (sc_po_check): Fix fatal typo in yesterday's change.
Patch by Bruno Haible.
---
 ChangeLog    |    6 ++++++
 top/maint.mk |    2 +-
 2 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 903adf6..1b42d3c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2011-03-19  Jim Meyering  <address@hidden>
+
+       maint.mk: fix po-file syntax-check rule
+       * top/maint.mk (sc_po_check): Fix fatal typo in yesterday's change.
+       Patch by Bruno Haible.
+
 2011-03-19  Bruno Haible  <address@hidden>

        socklen: Update comment.
diff --git a/top/maint.mk b/top/maint.mk
index 6dde022..fd192c9 100644
--- a/top/maint.mk
+++ b/top/maint.mk
@@ -961,7 +961,7 @@ sc_po_check:
          grep -E -v '^(#|$$)' $(po_file)                               \
            | grep -v '^src/false\.c$$' | sort > address@hidden;                
        \
          files=;                                                       \
-         for file in $$($(VC_LIST_EXCEPT)) $(srcdir)lib/*.[ch]; do     \
+         for file in $$($(VC_LIST_EXCEPT)) $(srcdir)/lib/*.[ch]; do    \
            test -r $$file || continue;                                 \
            case $$file in                                              \
              *.m4|*.mk) continue ;;                                    \
--
1.7.4.1.499.g53f9