bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: proposed patch for bootstrap


From: Eric Blake
Subject: Re: proposed patch for bootstrap
Date: Tue, 05 Apr 2011 13:58:39 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.9

On 04/05/2011 01:19 PM, Bruce Korb wrote:
> This fixes two things:
> 
> 1. "gnulib_extra_files" should not be computed before sourcing the
>    bootstrap.conf file, unless you intend that overriding build_aux
>    forces overriding gnulib_extra_files, too.  I don't think so, so
>    I deferred its computation until afterward.
> 
> 2. I also ran into a problem with auto-sorting of an order-dependent
>    file.  Below simply appends a file name if it is not found, leaving
>    the original order above the newly inserted entry.  Changed the
>    function name, too.

These should be split into two separate commits, since they touch two
separate issues.

I think I'm okay with your resolution for the first issue.  However,

> 
> If approved, I'll make it an official patch with two commits and
> ChangeLog entries.

your solution for the second issue conflicts with my proposed patch for:
http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/25869

What order-dependent sorting rules do you have, that would not already
be covered by sinking ! lines to the bottom of the .gitignore file per
the patch I just posted there?

-- 
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]