Re: proposed patch for bootstrap

[Bruce Korb]

On 04/05/11 12:58, Eric Blake wrote:
> On 04/05/2011 01:19 PM, Bruce Korb wrote:
> > This fixes two things:
> >
> > 1. "gnulib_extra_files" should not be computed before sourcing the
> >     bootstrap.conf file, unless you intend that overriding build_aux
> >     forces overriding gnulib_extra_files, too.  I don't think so, so
> >     I deferred its computation until afterward.
> >
> > 2. I also ran into a problem with auto-sorting of an order-dependent
> >     file.  Below simply appends a file name if it is not found, leaving
> >     the original order above the newly inserted entry.  Changed the
> >     function name, too.
>
> These should be split into two separate commits, since they touch two
> separate issues.

Yep.  I think we're in less-than-vehement agreement here. :)

> I think I'm okay with your resolution for the first issue.  However,
> your solution for the second issue conflicts with my proposed patch for:
> http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/25869
>
> What order-dependent sorting rules do you have, that would not already
> be covered by sinking ! lines to the bottom of the .gitignore file per
> the patch I just posted there?

The order-that-I-put-them-in rule.  In general, I think I understand
stuff better than a computer, so why am I being over-ruled?
The hypothetical and still somewhat concrete issue is the sequence:

1.  ignore this file pattern
2.  but don't ignore this pattern ('!' prefix)
3.  but do ignore this specific file

sinking to the bottom causes #2 to override #3, but I don't have that
problem.  It is theoretical until someone stubs their toe.
For me, the difference is that when I want a particular order,
I don't think that tools should go in and correct me. :)

That said, I'll leave it your call and only make the first patch.