Re: proposed patch for bootstrap

[Bruce Korb]

On 04/05/11 13:40, Eric Blake wrote:
> > The order-that-I-put-them-in rule.  In general, I think I understand
> > stuff better than a computer, so why am I being over-ruled?
>
> I tend to like sorted files (if nothing else, the human brain is much
> better at finding lines in a sorted file than a random one,

  Ctl-u Alt-| sort <enter>

If your .gitignore file is so long that it needs to be alphabetized
in order to make sense of it, maybe there are other problems. ;)

> 2) anyone that has a project that relies on ignore rules hairy enough
> to require manual layout has probably got other issues,.....
>
> Hmm, this also points back to Gary Vaughan's ideas to modularize

Good idea.  Put the "insert_sorted_vc_ignore" function before the
sourcing of bootstrap.conf.  I like it.  Problem solved.

> Tell you what - let's compromise :)
>
> I'll commit my patch now (it fixes a real bug for libvirt), and gladly
> let you commit yours at any future date, if and when you actually need
> it.

Not likely any time soon.  Especially with insert_sorted_vc_ignore
renamed to add_unique_line and defined before the configure file
gets sourced.  (Renaming since it is not required to sort and
it really isn't hard coded to only doing the work for some .FOOignore
file anyway.)

In the future, I'll promise to try to remember you don't like
extra curly braces.

Cheers - Bruce