Re: Failed builds for gzip/grep/rcs with latest gnulib revisions

[Jim Meyering]

Rob Vermaas wrote:
> since 2 days we are experiencing some errors in builds of some GNU packages
> (like gzip, grep, rcs). These packages are built continuously with the latest
> gnulib revision.
> An example can be found here: http://hydra.nixos.org/build/1043400 (log
> available at http://hydra.nixos.org/build/1043400/log)
>
> The logs show:
>
> ./bootstrap: aclocal --force -I m4  ...
> missing file lib/stdio-write.c
> configure.ac:44: error: expected source file, required through AC_LIBSOURCES, 
> not found
> m4/gnulib-comp.m4:180: gl_INIT is expanded from...
> configure.ac:44: the top level
> autom4te: /nix/store/ckck5bz4zsfjblp58crhr79q4ybppfrr-gnum4-1.4.15/bin/m4 
> failed with exit status: 1
> .aclocal-wrapped: autom4te failed with exit status: 1
>
> The commit that seems to cause this error:
> http://git.savannah.gnu.org/cgit/gnulib.git/diff/?id=
> 836e0457064eb3b0b21bd2d4954cbc428a6b6277&id2=
> fb799692f5bb43310424977e0ca15599fc68d776
>
> Is this intended behaviour (I suspect not, therefore this mail).

Hi Rob,

Thanks for the report.
That's because stdio_h.m4 now does this:

  if test $REPLACE_STDIO_WRITE_FUNCS = 1; then
    AC_LIBOBJ([stdio-write])
  fi

Yet the stdio module did not include lib/stdio-write.c.

Does this (untested) patch fix it for you?
I'll wait to hear from Bruno before pushing this.

From ee76b466967325b420c47dd7de2d489983aee5ff Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Fri, 15 Apr 2011 10:29:48 +0200
Subject: [PATCH] stdio: add new dependent to list of Files: lib/stdio-write.c

* modules/stdio (Files): Add lib/stdio-write.c.
Reported by Rob Vermaas.
---
 ChangeLog     |    6 ++++++
 modules/stdio |    1 +
 2 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index b6fdfdd..c400725 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2011-04-15  Jim Meyering  <address@hidden>
+
+       stdio: add new dependent to list of Files: lib/stdio-write.c
+       * modules/stdio (Files): Add lib/stdio-write.c.
+       Reported by Rob Vermaas.
+
 2011-04-14  Bruno Haible  <address@hidden>

        Support non-blocking pipe I/O in read() on native Windows.
diff --git a/modules/stdio b/modules/stdio
index 376e75f..72886ee 100644
--- a/modules/stdio
+++ b/modules/stdio
@@ -3,6 +3,7 @@ A GNU-like <stdio.h>.

 Files:
 lib/stdio.in.h
+lib/stdio-write.c
 m4/stdio_h.m4

 Depends-on:
--
1.7.5.rc1.228.g86d60b