Re: [1/7] Proposed patches to remove several inttypes-related dependencies

[Bruno Haible]

Hi Paul,

> @@ -27,4 +34,5 @@ AC_DEFUN([gl_FUNC_STRTOIMAX],
>  AC_DEFUN([gl_PREREQ_STRTOIMAX], [
>    AC_CHECK_DECLS([strtoll])
>    AC_REQUIRE([AC_TYPE_LONG_LONG_INT])
> +  gl_FUNC_STRTOLL
>  ])
> diff --git a/modules/strtoimax b/modules/strtoimax
> index 9f82af4..df6c88a 100644
> --- a/modules/strtoimax
> +++ b/modules/strtoimax
> @@ -3,11 +3,13 @@ strtoimax() function: convert string to 'intmax_t'.
>  
>  Files:
>  lib/strtoimax.c
> +lib/strtol.c
> +lib/strtoll.c
>  m4/longlong.m4
>  m4/strtoimax.m4
> +m4/strtoll.m4
>  
>  Depends-on:
> -strtoll
>  verify
>  inttypes
>  stdint

This patch hampers maintainability: Future changes to the 'strtoll' module
will likely require changes to the 'strtoimax' module.

In my opinion, this is another case where a conditional dependency between
modules is needed, cf. what we talked about two weeks ago [1].

Bruno

[1] http://lists.gnu.org/archive/html/bug-gnulib/2011-04/msg00086.html
-- 
In memoriam Siamanto <http://en.wikipedia.org/wiki/Siamanto>