[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] getcwd: consolidate m4 files
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH 1/3] getcwd: consolidate m4 files |
|
Date: |
Tue, 26 Apr 2011 11:59:39 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.9 |
On 04/25/2011 11:55 PM, Jim Meyering wrote:
> Eric Blake wrote:
>> It was confusing having 1 out of 3 known getcwd problems checked
>> in place, and the other two in separate files.
>>
>> * m4/getcwd-abort-bug.m4, m4/getcwd-path-max.m4: Delete, moving
>> contents...
>> * m4/getcwd.m4: Here.
>> * modules/getcwd (Files): Reflect the motion.
>
> I have mixed feelings about this. On one hand, it's obviously safe.
> On the other, it would make getcwd.m4 the 9th largest of
> gnulib's 600+ .m4 files.
Fair enough. I'll keep them separate, but update the comments (such as
the grammar error that got copied into the tests in patch 3/3).
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature