[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCHv2 5/9] dirent-safer: drop unused link dependency
From: |
Eric Blake |
Subject: |
Re: [PATCHv2 5/9] dirent-safer: drop unused link dependency |
Date: |
Tue, 26 Apr 2011 19:28:42 -0600 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.9 |
On 04/26/2011 05:35 PM, Eric Blake wrote:
> Ever since commit 2392b18099, fdopendir no longer drags in xalloc-die
> through indirect dependencies, so this test no longer needs $(LIBINTL).
>
> * modules/dirent-safer-tests (Makefile.am): Drop stale LDADD.
NAK to this patch (but that doesn't affect the other 8 in the series).
In isolation, test-dirent-safer doesn't use fdopendir; but with
dirent-safer and fdopendir used at the same time, then xalloc is still
being pulled in. That is, commit 2392b18 dropped xalloc-die for openat,
but fdopendir is using more than openat and still dragging in xalloc
through some other path.
[Hmm, './gnulib-tool --test openat' excludes xalloc-die, but
'./gnulib-tool --test --with-tests openat' pulls it in - I'm still
investigating...]
> +++ b/modules/dirent-safer-tests
> @@ -10,6 +10,3 @@ configure.ac:
> Makefile.am:
> TESTS += test-dirent-safer
> check_PROGRAMS += test-dirent-safer
> -# Link with libintl when needed. dirent-safer uses fdopendir if it is
> present,
> -# and fdopendir indirectly depends on xgetcwd -> xalloc-die -> gettext-h.
> -test_dirent_safer_LDADD = $(LDADD) $(LIBINTL)
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [PATCHv2 4/9] save-cwd: reduce dependency, (continued)
[PATCHv2 2/9] getcwd-lgpl: new module, Eric Blake, 2011/04/26
[PATCHv2 5/9] dirent-safer: drop unused link dependency, Eric Blake, 2011/04/26
- Re: [PATCHv2 5/9] dirent-safer: drop unused link dependency,
Eric Blake <=
[PATCHv2 6/9] tests: reduce dependencies, Eric Blake, 2011/04/26
[PATCHv2 3/9] getcwd: enhance tests, Eric Blake, 2011/04/26
[PATCHv2 7/9] linkat, renameat: add missing dependency, Eric Blake, 2011/04/26
[PATCHv2 8/9] filenamecat-lgpl: fix licence, Eric Blake, 2011/04/26
[PATCHv2 9/9] fchdir: avoid extra chdir and fix test, Eric Blake, 2011/04/26