Re: VC-tag again

[Jim Meyering]

Reuben Thomas wrote:
> On 29 April 2011 20:51, Reuben Thomas <address@hidden> wrote:
>> On 29 April 2011 20:49, Jim Meyering <address@hidden> wrote:
>>>
>>> Hmm... in grep's README-release, I count five URLs containing
>>> the package name:
>>>
>>>    http://hydra.nixos.org/jobset/gnu/grep-master
>>>    https://savannah.gnu.org/projects/grep/
>>>    https://savannah.gnu.org/project/admin/editgroupfeatures.php?group=grep
>>>    https://savannah.gnu.org/news/approve.php?group=grep
>>>    http://www.gnu.org/software/grep/manual/
>>>
>>> When making a release, I usually mouse at least 3 of those
>>> into a browser.  Having to deal with "generic" links like these
>>> would be less useful to me:
>>
>> Fair enough.
>
> First go attached. I couldn't work out how to add README-release to
> the top-level .gitignore.

I've just realized there's a good way to avoid that altogether.
See below.

> I also seem to have done something wrong with the changelog (bogus
> extra line in the commit message from vc-dwim) but I can't see what.

That's due to a bug in vc-dwim.  When two ChangeLog entries
like that have the same author, diff output may include not
the topmost one, but rather the second one, and the diff-parsing
code doesn't handle that.  I'll take a look

> Subject: [PATCH 2/2] readme-release: Add new module with release instructions.
>
> * modules/readme-release: new module.
> * top/README-release.in: template file.
>
> 2011-04-29  Reuben Thomas  <address@hidden>
> ---
>  ChangeLog              |    6 +++
>  modules/readme-release |   20 +++++++++++
>  top/README-release.in  |   89 
> ++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 115 insertions(+), 0 deletions(-)
>  create mode 100644 modules/readme-release
>  create mode 100644 top/README-release.in
>
> diff --git a/ChangeLog b/ChangeLog
> index c920eb7..af443c6 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,5 +1,11 @@
>  2011-04-29  Reuben Thomas  <address@hidden>
>
> +     readme-release: Add new module with release instructions.
> +     * modules/readme-release: new module.
> +     * top/README-release.in: template file.
> +
> +2011-04-29  Reuben Thomas  <address@hidden>
> +
>       announce-gen: cosmetic improvement
>       * build-aux/announce-gen: strip any leading ./ from the NEWS file.
>
> diff --git a/modules/readme-release b/modules/readme-release
> new file mode 100644
> index 0000000..20033fc
> --- /dev/null
> +++ b/modules/readme-release
> @@ -0,0 +1,20 @@
> +Description:
> +Add release instructions customized for the package.
> +
> +Files:
> +top/README-release.in
> +
> +Depends-on:
> +
> +configure.ac:
> +AC_CONFIG_FILES([README-release])

In general, it is good not to use AC_CONFIG_FILES for this.
You can remove that line.

Instead, simply recommend to add something like this in autogen.sh
or in bootstrap.conf's bootstrap_epilogue function:

  perl -pi -e "s/address@hidden@/$package/g" README-release


> +Makefile.am:
> +
> +Include:
> +
> +License:
> +GPLed build tool
> +
> +Maintainer:
> address@hidden
> diff --git a/top/README-release.in b/top/README-release.in
> new file mode 100644
> index 0000000..69841d2
> --- /dev/null
> +++ b/top/README-release.in
> @@ -0,0 +1,89 @@
> +Here are most of the steps we (maintainers) follow when making a release.
> +
> +* start from a clean, up-to-date git directory.
...