bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: dependency creep: canonicalize_file_name


From: Sam Steingold
Subject: Re: dependency creep: canonicalize_file_name
Date: Wed, 04 May 2011 13:21:30 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)

> * Eric Blake <address@hidden> [2011-05-04 10:03:36 -0600]:
> On 05/04/2011 09:51 AM, Sam Steingold wrote:
>> And yet again it is time for me to bitch about dependency creep.
>> 
>> discovered that it offered canonicalize_file_name instead.
>
> Try canonicalize-lgpl instead; much lighter-weight, and is the only
> module that gives you a working realpath().

Indeed, much better:

$ wc `hg st -u | cut -c2-`
  378  1324 10439 src/gllib/canonicalize-lgpl.c
   53   261  2011 src/gllib/dosname.h
   91   490  3191 src/gllib/lstat.c
   48   227  1525 src/gllib/pathmax.h
   74   347  2355 src/gllib/readlink.c
  105   458  3425 src/gllib/stat.c
  658  2489 18324 src/gllib/sys_stat.in.h
  249  1093  9223 src/gllib/time.in.h
   94   274  2986 src/glm4/canonicalize.m4
   38   212  1621 src/glm4/double-slash-root.m4
   69   274  2652 src/glm4/lstat.m4
   13    55   441 src/glm4/pathmax.m4
   62   210  2218 src/glm4/readlink.m4
   66   250  2436 src/glm4/stat.m4
   82   259  3278 src/glm4/sys_stat_h.m4
  109   305  4247 src/glm4/time_h.m4
 2189  8528 70372 total

Still I get 2000+ lines to replace 200- lines I have.

>> People, this is ridiculous.
>
> canonicalize no longer even provides realpath().  But again,

I would be perfectly fine with canonicalize_file_name() instead of realpath().

> realpath.texi tells you to use canonicalize-lgpl rather than canonicalize.

What I was complaining about is that I have to pull 150+ _files_ to define
a function whose C code takes about the same number of _lines_.

-- 
Sam Steingold (http://sds.podval.org/) on CentOS release 5.6 (Final) X 
11.0.60900031
http://thereligionofpeace.com http://jihadwatch.org http://dhimmi.com
http://honestreporting.com http://truepeace.org
Single tasking: Just Say No.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]