[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] openat: reduce syscalls in first probe of /proc
|
From: |
Bruno Haible |
|
Subject: |
Re: [PATCH] openat: reduce syscalls in first probe of /proc |
|
Date: |
Tue, 10 May 2011 01:15:05 +0200 |
|
User-agent: |
KMail/1.9.9 |
Eric Blake wrote:
> - int proc_self_fd = open ("/proc/self/fd", O_SEARCH);
> + int proc_self_fd = open ("/proc/self/fd",
> + O_SEARCH | O_DIRECTORY | O_NOCTTY |
> O_NONBLOCK);
What is the point of playing with O_NOCTTY and O_NONBLOCK here?
It could trigger bugs in dark untested areas of the kernels, so why do it?
Bruno
--
In memoriam Aldo Moro <http://en.wikipedia.org/wiki/Aldo_Moro>