bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: do I need "ifdef HAVE_UNISTD_H" if I import unistd?


From: Sam Steingold
Subject: Re: do I need "ifdef HAVE_UNISTD_H" if I import unistd?
Date: Mon, 16 May 2011 17:44:30 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)

> * Eric Blake <address@hidden> [2011-05-16 15:30:04 -0600]:
>
>> why doesn't vc-list-files accept a list of directories?
>
> Patches welcome; seems like a useful addition.



--- /home2/sds/src/clisp/current/gnulib/build-aux/vc-list-files 2011-05-03 
12:08:03.000000000 -0400
+++ /home2/sds/src/clisp/current/src/build-aux/vc-list-files    2011-05-16 
17:42:00.000000000 -0400
@@ -2,7 +2,7 @@
 # List version-controlled file names.
 
 # Print a version string.
-scriptversion=2011-04-29.20; # UTC
+scriptversion=2011-05-16.21; # UTC
 
 # Copyright (C) 2006-2011 Free Software Foundation, Inc.
 
@@ -30,7 +30,7 @@ scriptversion=2011-04-29.20; # UTC
 postprocess=
 case $1 in
   --help) cat <<EOF
-Usage: $0 [-C SRCDIR] [DIR]
+Usage: $0 [-C SRCDIR] [DIR...]
 
 Output a list of version-controlled files in DIR (default .), relative to
 SRCDIR (default .).  SRCDIR must be the top directory of a checkout.
@@ -61,16 +61,10 @@ EOF
     shift; shift ;;
 esac
 
-dir=
-case $# in
-  0) ;;
-  1) dir=$1 ;;
-  *) echo "$0: too many arguments" 1>&2
-     echo "Usage: $0 [-C srcdir] [DIR]" 1>&2; exit 1;;
-esac
-
-test "x$dir" = x && dir=.
+dirs=$*
+test "x$dirs" = x && dirs=.
 
+for dir in $dirs; do
 if test -d .git; then
   test "x$dir" = x. \
     && dir= sed_esc= \
@@ -108,6 +102,7 @@ else
   echo "$0: Failed to determine type of version control used in `pwd`" 1>&2
   exit 1
 fi
+done
 
 # Local variables:
 # eval: (add-hook 'write-file-hooks 'time-stamp)

Diff finished.  Mon May 16 17:42:25 2011







>> (it would be 'src modules' for me)
>> why is $(srcdir)/lib/ hard-coded? I use gllib instead of lib.
>
> Where is it hard-coded?  We've been trying to get rid of hard-coded
> aspects, but we can only fix things as they are pointed out.

--- /home2/sds/src/clisp/current/gnulib/top/maint.mk    2011-05-16 
16:32:49.000000000 -0400
+++ /home2/sds/src/clisp/current/maint.mk       2011-05-16 17:20:23.000000000 
-0400
@@ -681,7 +681,7 @@ sc_useless_cpp_parens:
 # #if HAVE_HEADER_H that you remove, be sure that your project explicitly
 # requires the gnulib module that guarantees the usability of that header.
 gl_assured_headers_ = \
-  cd $(gnulib_dir)/lib && echo *.in.h|sed 's/\.in\.h//g'
+  cd $(gnulib_dir) && echo *.in.h|sed 's/\.in\.h//g'
 
 # Convert the list of names to upper case, and replace each space with "|".
 az_ = abcdefghijklmnopqrstuvwxyz
@@ -718,7 +718,7 @@ gl_extract_significant_defines_ = \
 # of macros that are guaranteed to be defined by parts of gnulib.
 define def_sym_regex
        gen_h=$(gl_generated_headers_);                                 \
-       (cd $(gnulib_dir)/lib;                                          \
+       (cd $(gnulib_dir);                                              \
          for f in *.in.h $(gl_other_headers_); do                      \
            perl -lne '$(gl_extract_significant_defines_)' $$f;         \
          done;                                                         \
@@ -1049,7 +1049,7 @@ writable-files:
          test "$$fail" && exit 1 || : ;                                \
        fi
 
-v_etc_file = $(gnulib_dir)/lib/version-etc.c
+v_etc_file = $(gnulib_dir)/version-etc.c
 sample-test = tests/sample-test
 texi = doc/$(PACKAGE).texi
 # Make sure that the copyright date in $(v_etc_file) is up to date.

Diff finished.  Mon May 16 17:43:03 2011



-- 
Sam Steingold (http://sds.podval.org/) on CentOS release 5.6 (Final) X 
11.0.60900031
http://pmw.org.il http://www.memritv.org http://honestreporting.com
http://mideasttruth.com http://www.PetitionOnline.com/tap12009/
char*a="char*a=%c%s%c;main(){printf(a,34,a,34);}";main(){printf(a,34,a,34);}



reply via email to

[Prev in Thread] Current Thread [Next in Thread]