[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] getopt: for ambiguous options, enumerate the possibilities.
From: |
Bruno Haible |
Subject: |
Re: [PATCH] getopt: for ambiguous options, enumerate the possibilities. |
Date: |
Wed, 25 May 2011 00:11:22 +0200 |
User-agent: |
KMail/1.9.9 |
Hi James,
Thanks for having dealt with the second and third point of
<http://lists.gnu.org/archive/html/bug-gnulib/2011-05/msg00321.html>.
What about the first one? Can you just add the reference to
<http://sourceware.org/bugzilla/show_bug.cgi?id=7101> in the ChangeLog entry?
And also, when you talk about "glibc change", add either an URL or the date
of that change? It would help future analyzes a lot to have the precise
references.
> + if (ambig_list != NULL)
> + {
> + do
> + {
> + struct option_list *pn = ambig_list->next;
> + free (ambig_list);
> + ambig_list = pn;
> + } while (ambig_list != NULL);
> + }
> +
It seems to me that I see again tabs here.
Also, this loop could be written in a simpler way as
while (ambig_list != NULL)
{
struct option_list *pn = ambig_list->next;
free (ambig_list);
ambig_list = pn;
}
Bruno
--
In memoriam Georges Darboy <http://en.wikipedia.org/wiki/Georges_Darboy>
- [PATCH] getopt: for ambiguous options, enumerate the possibilities., James Youngman, 2011/05/15
- Re: [PATCH] getopt: for ambiguous options, enumerate the possibilities., Bruno Haible, 2011/05/15
- [PATCH] getopt: for ambiguous options, enumerate the possibilities., James Youngman, 2011/05/24
- Re: [PATCH] getopt: for ambiguous options, enumerate the possibilities.,
Bruno Haible <=
- [PATCH] getopt: for ambiguous options, enumerate the possibilities., James Youngman, 2011/05/25
- Re: [PATCH] getopt: for ambiguous options, enumerate the possibilities., Bruno Haible, 2011/05/26
- Re: [PATCH] getopt: for ambiguous options, enumerate the possibilities., Jim Meyering, 2011/05/26
- Re: [PATCH] getopt: for ambiguous options, enumerate the possibilities., Eric Blake, 2011/05/26