bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCHv2] strerror: drop strerror_r dependency


From: Bruno Haible
Subject: Re: [PATCHv2] strerror: drop strerror_r dependency
Date: Sat, 4 Jun 2011 13:02:26 +0200
User-agent: KMail/1.9.9

Eric Blake wrote:
> * lib/strerror-impl.h: Delete.

The comments still refer to this file. Fixing it like this:


2011-06-04  Bruno Haible  <address@hidden>

        strerror_r: Fix comments.
        * lib/strerror_r.c (strerror_r): Update comments after 2011-06-01
        commit.

--- lib/strerror_r.c.orig       Sat Jun  4 12:59:43 2011
+++ lib/strerror_r.c    Sat Jun  4 12:56:09 2011
@@ -181,9 +181,8 @@
       {
         char stackbuf[STACKBUF_LEN];
 
-        /* strerror-impl.h is also affected if our choice of stackbuf
-           size is not large enough.  */
         if (strerror_r (errnum, stackbuf, sizeof stackbuf) == ERANGE)
+          /* STACKBUF_LEN should have been large enough.  */
           abort ();
         safe_copy (buf, buflen, stackbuf);
       }
@@ -198,7 +197,7 @@
         size_t len;
         strerror_r (errnum, stackbuf, sizeof stackbuf);
         len = strlen (stackbuf);
-        /* stackbuf should have been large enough.  */
+        /* STACKBUF_LEN should have been large enough.  */
         if (len + 1 == sizeof stackbuf)
           abort ();
         if (buflen <= len)
-- 
In memoriam Mordechai Gebirtig <http://en.wikipedia.org/wiki/Mordechai_Gebirtig>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]