[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests: fix usage message in 'mktempd_'
From: |
Eric Blake |
Subject: |
Re: [PATCH] tests: fix usage message in 'mktempd_' |
Date: |
Tue, 07 Jun 2011 06:11:47 -0600 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.10 |
On 06/07/2011 05:57 AM, Stefano Lattarini wrote:
> * tests/init.sh (mktempd_): In the usage message, use literal
> 'mktempd_', not '$ME' (which is even undefined), as the name of
> the subroutine.
> ---
> ChangeLog | 7 +++++++
> tests/init.sh | 2 +-
> 2 files changed, 8 insertions(+), 1 deletions(-)
$ME is undefined, but $ME_ is defined earlier to init.sh; I think the
original bug was a missing trailing underscore.
However, within the function mktempd_, it seems like it is better to use
the function name than the overall dot-file name in the usage message
for that function.
So I like this patch as-is.
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature