bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests: fix usage message in 'mktempd_'


From: Stefano Lattarini
Subject: Re: [PATCH] tests: fix usage message in 'mktempd_'
Date: Tue, 7 Jun 2011 15:14:34 +0200
User-agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; )

On Tuesday 07 June 2011, Eric Blake wrote:
> On 06/07/2011 05:57 AM, Stefano Lattarini wrote:
> > * tests/init.sh (mktempd_): In the usage message, use literal
> > 'mktempd_', not '$ME' (which is even undefined), as the name of
> > the subroutine.
> > ---
> >  ChangeLog     |    7 +++++++
> >  tests/init.sh |    2 +-
> >  2 files changed, 8 insertions(+), 1 deletions(-)
> 
> $ME is undefined, but $ME_ is defined earlier to init.sh; I think the
> original bug was a missing trailing underscore.
> 
> However, within the function mktempd_, it seems like it is better to use
> the function name than the overall dot-file name in the usage message
> for that function.
> 
> So I like this patch as-is.
> 
I've pushed the patch now.

Thanks,
  Stefano



reply via email to

[Prev in Thread] Current Thread [Next in Thread]