bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] maint.mk: correct omissions in prohibit_argmatch_without_use che


From: Jim Meyering
Subject: [PATCH] maint.mk: correct omissions in prohibit_argmatch_without_use check
Date: Sun, 03 Jul 2011 23:06:49 +0200

FYI,

>From 84fb438212273a62452a0eea47dc695e0c3c911f Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Sun, 3 Jul 2011 23:00:15 +0200
Subject: [PATCH] maint.mk: correct omissions in prohibit_argmatch_without_use
 check

This rule would mistakenly report that argmatch.h is included without
use even when both the argmatch and invalid_arg macro were used.
* top/maint.mk (sc_prohibit_argmatch_without_use): Also detect uses
of argmatch and invalid_arg.
---
 ChangeLog    |    8 ++++++++
 top/maint.mk |    2 +-
 2 files changed, 9 insertions(+), 1 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 79b10be..4939b80 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2011-07-03  Jim Meyering  <address@hidden>
+
+       maint.mk: correct omissions in prohibit_argmatch_without_use check
+       This rule would mistakenly report that argmatch.h is included without
+       use even when both the argmatch and invalid_arg macro were used.
+       * top/maint.mk (sc_prohibit_argmatch_without_use): Also detect uses
+       of argmatch and invalid_arg.
+
 2011-07-03  Bruno Haible  <address@hidden>

        Comments about EINTR.
diff --git a/top/maint.mk b/top/maint.mk
index e6e03a8..725e52d 100644
--- a/top/maint.mk
+++ b/top/maint.mk
@@ -516,7 +516,7 @@ sc_prohibit_safe_read_without_use:

 sc_prohibit_argmatch_without_use:
        @h='argmatch.h' \
-       
re='(\<(ARRAY_CARDINALITY|X?ARGMATCH(|_TO_ARGUMENT|_VERIFY))\>|\<argmatch(_exit_fn|_(in)?valid)
 *\()' \
+       
re='(\<(ARRAY_CARDINALITY|X?ARGMATCH(|_TO_ARGUMENT|_VERIFY))\>|\<(invalid_arg|argmatch(_exit_fn|_(in)?valid)?)
 *\()' \
          $(_sc_header_without_use)

 sc_prohibit_canonicalize_without_use:
--
1.7.6.370.gfeac5



reply via email to

[Prev in Thread] Current Thread [Next in Thread]