Re: [PATCH] fts: introduce FTS_NOATIME

[Eric Blake]

On 07/07/2011 03:07 PM, Eric Blake wrote:
> On 07/07/2011 03:02 PM, Paul Eggert wrote:
>> On 07/07/11 10:41, Eric Blake wrote:
>>> This gives clients the option to try a non-invasive traversal,
>>
>> Thanks for doing that; a couple of minor comments:
>>
>>> -            int fd = open (".", O_SEARCH);
>>> +            int fd = open (".",
>>> +                           O_SEARCH | (ISSET (FTS_NOATIME) ? O_NOATIME : 
>>> 0));
>>
>> Shouldn't this use diropen rather than open?  Then you don't need
>> to worry about checking the flag here.  (This comment applies to
>> the existing code, too.)
> 
> Possibly.  Jim?

Then again, maybe not.  This particular open() is done in early
initialization, and diropen() assumes that the rest of the fts struct
internals have already been initialized.  That is, diropen() may fail if
called this early.

-- 
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature