[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] getopt-gnu: avoid crash in glibc getopt
|
From: |
Pádraig Brady |
|
Subject: |
Re: [PATCH] getopt-gnu: avoid crash in glibc getopt |
|
Date: |
Tue, 19 Jul 2011 17:31:23 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3 |
On 19/07/11 16:34, Eric Blake wrote:
> On 07/19/2011 03:55 AM, Pádraig Brady wrote:
>> On 07/07/11 17:57, Eric Blake wrote:
>>> Use of "W;" in an option string may be rare, but we might as well
>>> avoid crashing on it.
>>>
>>> * m4/getopt.m4 (gl_GETOPT_CHECK_HEADRS): Detect the problem.
>>
>> I noticed core files which are due to this I think.
>> Should it be protected with m4/nocrash.m4 ?
>
> Does nocrash.m4 prevent core files on Linux, or is it just for
> preventing modal popup boxes on other OS?
It prevents cores on Linux at least.
Note my Fedora system is configured to include pids in the core files,
and the generic ./configure cleanup code does not remove those.
> But if it improves the
> situation, then I'm okay with a patch - would you care to submit one?
Attached.
cheers,
Pádraig.
getopt-cores.diff
Description: Text Data
[PATCH] getopt: avoid compiler warning during configure, Eric Blake, 2011/07/07