Re: [PATCH] getopt-gnu: avoid crash in glibc getopt

[Pádraig Brady]

On 19/07/11 20:33, Bruno Haible wrote:
> Eric Blake asked:
>>> Does nocrash.m4 prevent core files on Linux, or is it just for
>>> preventing modal popup boxes on other OS?
> 
> The comments in m4/nocrash.m4 say it:
> 
>    ...This is useful to avoid triggering
>    action from a background debugger and to avoid core dumps.
> 
> Pádraig Brady wrote:
>> Note my Fedora system is configured to include pids in the core files,
> 
> Hence "rm -f core" in a configure test would be wrong. Hmm, is gnulib is
> the only package that has configure tests that may crash, or would it
> be useful to move the 'nocrash' module to Autoconf (in the form of an
> Autoconf built-in)?

That might be useful yes.
Also it might be worth adding core.[0-9]* to the list to delete?

> 
>> Attached.
> 
> Nearly perfect. Just this code here
> 
>              nocrash_init();
> 
>              int result = 0;
> 
> uses C99 features not in C89 (declaration after statement). Swap these, and
> the patch is fine.

Heh, I surprised myself and already caught that.

change now pushed.

cheers,
Pádraig.