bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: new module timer-time


From: Pádraig Brady
Subject: Re: new module timer-time
Date: Wed, 20 Jul 2011 10:01:21 +0100
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3

On 20/07/11 02:30, Bruno Haible wrote:
> Pádraig Brady wrote:
>> [timer-time.diff attachment]
> 
>> +Check for timer_settime.  Within HAVE_TIMER_SETTIME one can
>> +assume timer_create is available too, as that is a
>> +prerequisite to use timer_settime.
> 
> And timer_gettime as well. I've verified in the platformsxsymbols matrix
> that timer_create, timer_gettime, timer_settime are available in the same
> way on all platforms:

Thanks for checking!

> MISSING in          beos freebsd-5.2.1 freebsd-6.0 freebsd-6.4 interix-3.5 
> irix-5.3 macosx-10.3 macosx-10.4 macosx-10.5 mingw nsk-G06 pips solaris-2.4

I'll update doc/posix-functions/timer_* (except timer_getoverrun)
to add Tandem/NSK and s/FreeBSD 6.0/FreeBSD 6.4/ as part of the patch.

I've also updated the "Gnulib module:" line in those docs
which I was unsure about doing.

>> +# foo_LDADD = $(LDADD) $(LIB_TIMER_TIME)
> 
> This comment is redundant: The 'Link' field in the module specification
> also says it.
> 
>> +Include:
>> +
> 
> This looks wrong: Users of these functions must include <time.h>. So that's
> what you need to specify here.

Amended patch attached.

> While we are at it: What can <time.h> do to define these functions on 
> platforms
> that lack it?

Well I suppose you could emulate a subset of timer_settime with setitimer,
but it would be awkward and I don't need that functionality at present.

cheers,
Pádraig.

Attachment: timer-time.diff
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]