bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] test-select.h: avoid warning from gcc's -Wmissing-declarations


From: Jim Meyering
Subject: [PATCH] test-select.h: avoid warning from gcc's -Wmissing-declarations
Date: Sun, 24 Jul 2011 23:40:37 +0200

coreutils' "make check" started failing like this
with the latest from gnulib:

    In file included from test-select.c:30:0:
    test-select.h:365:1: error: no previous declaration for 'test_function' 
[-Werror=missing-declarations]
    cc1: all warnings being treated as errors

I'll push this in a few hours:


>From d72683055ea46253d8eb8f89341eff5414ae6ca0 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Sun, 24 Jul 2011 23:37:17 +0200
Subject: [PATCH] test-select.h: avoid warning from gcc's
 -Wmissing-declarations

* tests/test-select.h (test_function): Declare as "static".
---
 ChangeLog           |    5 +++++
 tests/test-select.h |    2 +-
 2 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 2d8964f..e7ca0e6 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2011-07-24  Jim Meyering  <address@hidden>
+
+       test-select.h: avoid warning when using gcc's -Wmissing-declarations
+       * tests/test-select.h (test_function): Declare as "static".
+
 2011-07-24  Bruno Haible  <address@hidden>

        doc: Mention the effects of AC_SYS_LARGEFILE.
diff --git a/tests/test-select.h b/tests/test-select.h
index 88abe17..1ddfda3 100644
--- a/tests/test-select.h
+++ b/tests/test-select.h
@@ -359,7 +359,7 @@ test_pipe (select_fn my_select)

 /* Do them all.  */

-int
+static int
 test_function (select_fn my_select)
 {
   int result;
--
1.7.6.609.gbf6a9



reply via email to

[Prev in Thread] Current Thread [Next in Thread]