bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: regex.m4: how do I know that the included regex is used?


From: Sam Steingold
Subject: Re: regex.m4: how do I know that the included regex is used?
Date: Fri, 29 Jul 2011 10:32:08 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)

> * Bruno Haible <address@hidden> [2011-07-29 01:39:59 +0200]:
>
>> At any rate, if gnulib regex is included in libgnu.a, then regex.h
>> should be copied (or linked) to $(builddir) or $(builddir)/gllib.
>> The current situation is clearly wrong: regex is the only gnulib package
>> which requires prepending -I$(srcdir)/gllib to CPPFLAGS!
>
> It is the package's responsibility to be consistent about $(builddir)
> vs. $(srcdir). Don't use
>    -I$(srcdir)/gllib
> or
>    -I$(builddir)/gllib
> in isolation. Always use
>    -I$(builddir)/gllib -I$(srcdir)/gllib
> so that -I options that come before it take precedence, -I options that come
> after have lower precedence, and files in $(builddir)/gllib hide possible
> (accidentally leftover) files in $(srcdir)/gllib.

well, instead of adding -I$(srcdir)/gllib, I symlink (shudder!!!) the
necessary headers into -I$(builddir):
in makemake.in:

GLLIB_MODULE_HEADERS="regex.h"
for f in localcharset.h ${GLLIB_MODULE_HEADERS} ${UNICODE_EXTRA}; do
  link_dep "${f}" `find ${SRCDIR}gllib/ -name ${f}`
done

which results in

regex.h : ../src/gllib/regex.h
        -$(RM) regex.h
        -$(LN_S) ../src/gllib/regex.h regex.h

streq.h : ../src/gllib/streq.h
        -$(RM) streq.h
        -$(LN_S) ../src/gllib/streq.h streq.h

cjk.h : ../src/gllib/uniwidth/cjk.h
        -$(RM) cjk.h
        -$(LN_S) ../src/gllib/uniwidth/cjk.h cjk.h

uninames.h : ../src/gllib/uniname/uninames.h
        -$(RM) uninames.h
        -$(LN_S) ../src/gllib/uniname/uninames.h uninames.h

the reason I cannot do -I$(srcdir)/gllib is clear: it will not catch
uninames.h & cjk.h.
on the other hand, it does not look like streq.h, uninames.h and cjk.h
are included in any clisp sources (only in gnulib).

so, I guess TRT is to remove the linking and add -I$(srcdir)/gllib to CPPFLAGS..

-- 
Sam Steingold (http://sds.podval.org/) on CentOS release 5.6 (Final) X 
11.0.60900031
http://iris.org.il http://honestreporting.com http://openvotingconsortium.org
http://mideasttruth.com http://www.PetitionOnline.com/tap12009/ http://ffii.org
A man paints with his brains and not with his hands.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]