bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH]


From: Iain Nicol
Subject: [PATCH]
Date: Sun, 31 Jul 2011 13:42:30 +0100

Hi,

Gnulib's file <build-aux/git-version-gen> contains copy-pastable usage
instructions.  It seems to me that these instructions are missing a
line.  As a result, for example, ``make distcheck'' in a clone of GNU
Patch's repo fails with the following:

echo 2.6.1.143-5862 > ../.version-t && mv ../.version-t ../.version
/bin/bash: ../.version-t: Permission denied

I notice that a few GNU projects (gcal, Guile, M4) explicitly add the
file ``.version'' to EXTRA_DIST.  This prevents the above distcheck
failure.

At first I wasn't sure if this was the right solution, but then I
noticed git-version-gen explicitly says:

  # .version - present in a checked-out repository and in a distribution
  # tarball.

Adding .version to EXTRA_DIST, unsurprisingly, seems to be required for
the latter half of that sentence to be true.

For lazy people like me who want copy pasted code to Just Work, please
consider making the need for this explicit in the instructions, like in
the attached patch.  Assuming you agree this is the right solution, that
is.


Regards,
-- 
Iain

Attachment: 0001-git-version-gen-avoid-users-encountering-a-make-dist.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]