Re: [PATCH] bzr-version-gen: New module.

[Bruno Haible]

Hello Giuseppe,

> I would like to contribute this new module.  I am using it for wget, it
> works like git-version-gen, except it supports Bazaar.

The git-version-gen script has a lot more comments and better error checking.
Surely you don't want to duplicate this code? How about, then, merging your
script with git-version-gen, and rename the module to 'vc-version-gen'?
(The prefix 'vc' would be consistent with vc-dwim and vc-changelog.)

> +test -n "$(bzr diff | tr -d '\n')" && DIRTY="-dirty"

The use of $(...) is not portable. Use `...` for portability.
For more on shell code portability, see the Autoconf manual
<http://www.gnu.org/software/autoconf/manual/html_node/Portable-Shell.html>
in particular
<http://www.gnu.org/software/autoconf/manual/html_node/Shell-Substitutions.html>

Bruno
-- 
In memoriam Janusz Korczak <http://en.wikipedia.org/wiki/Janusz_Korczak>