bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

relocatable-prog needs AC_LIBOBJ([relocatable])?


From: Ben Pfaff
Subject: relocatable-prog needs AC_LIBOBJ([relocatable])?
Date: Mon, 15 Aug 2011 21:58:16 -0700
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)

GNU PSPP includes relocatable C programs, so it uses the
relocatable-prog module, but it does not include a relocatable
shared library, so it does not use the relocatable-lib module.

Before commit 357d319ff8 "relocatable-lib: Move AC_LIBOBJ
invocations to module description", this worked fine.  But that
commit removed the call to AC_LIBOBJ([relocatable]) from
m4/relocatable.m4 in gl_RELOCATABLE_LIBRARY (which
relocatable-prog calls), moving it instead into
modules/relocatable-lib.  Since PSPP doesn't use the
relocatable-lib module, it doesn't build lib/relocatable.c.  This
causes link errors for relocate() and other functions.

The following fixes the link errors.  Is it the correct fix?

Thanks,

Ben.

diff --git a/modules/relocatable-prog b/modules/relocatable-prog
index a7f50ac..72bc253 100644
--- a/modules/relocatable-prog
+++ b/modules/relocatable-prog
@@ -28,6 +28,7 @@ configure.ac:
 gl_RELOCATABLE([$gl_source_base])
 if test $RELOCATABLE = yes; then
   AC_LIBOBJ([progreloc])
+  AC_LIBOBJ([relocatable])
 fi
 
 Makefile.am:


-- 
Ben Pfaff 
http://benpfaff.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]