Re: Ensuring posix-ness

[Bruno Haible]

Hi Reuben,

> > Certainly the fact that crypt() is not defined by default could be mentioned
> > in doc/posix-functions/crypt.texi.
> 
> Patch follows:
> 
> diff --git a/ChangeLog b/ChangeLog
> index 79d9777..9a64036 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,7 @@
> +2011-09-07  Reuben Thomas  <address@hidden>
> +
> +     crypt: Document that the function is not defined by default in glibc.
> +
>  2011-09-07  Bruno Haible  <address@hidden>
> 
>       openat: Work around compilation error with OSF/1 5.1 DTK cc.
> diff --git a/doc/posix-functions/crypt.texi b/doc/posix-functions/crypt.texi
> index b7f1927..7651d3e 100644
> --- a/doc/posix-functions/crypt.texi
> +++ b/doc/posix-functions/crypt.texi
> @@ -15,4 +15,7 @@ Portability problems not fixed by Gnulib:
>  @item
>  This function is missing on some platforms:
>  FreeBSD 6.0, NetBSD 5.0, Cygwin, mingw.
> address@hidden
> +Crypt is not defined by default on some platforms:
> +glibc.
>  @end itemize

Thanks. I've
  - changed "not defined" to "not declared" (sorry I made that mistake
    in the mail to which you replied),
  - added a mention of the glibc version (since it may change in future
    versions),
  - generalized the commit to cover also encrypt() and setkey().


2011-09-08  Reuben Thomas  <address@hidden>
            Bruno Haible  <address@hidden>

        Doc about crypt functions.
        * doc/posix-functions/crypt.texi: Mention need for _GNU_SOURCE on glibc
        systems.
        * doc/posix-functions/encrypt.texi: Likewise.
        * doc/posix-functions/setkey.texi: Likewise.

--- doc/posix-functions/crypt.texi.orig Thu Sep  8 11:57:23 2011
+++ doc/posix-functions/crypt.texi      Thu Sep  8 11:56:29 2011
@@ -15,4 +15,8 @@
 @item
 This function is missing on some platforms:
 FreeBSD 6.0, NetBSD 5.0, Cygwin, mingw.
address@hidden
+This function is not declared in @code{<unistd.h>}
+(without @code{-D_GNU_SOURCE}) on some platforms:
+glibc 2.11.
 @end itemize
--- doc/posix-functions/encrypt.texi.orig       Thu Sep  8 11:57:23 2011
+++ doc/posix-functions/encrypt.texi    Thu Sep  8 11:56:29 2011
@@ -15,4 +15,8 @@
 @item
 This function is missing on some platforms:
 NetBSD 5.0, Minix 3.1.8, Cygwin, mingw, BeOS.
address@hidden
+This function is not declared in @code{<unistd.h>}
+(without @code{-D_GNU_SOURCE}) on some platforms:
+glibc 2.11.
 @end itemize
--- doc/posix-functions/setkey.texi.orig        Thu Sep  8 11:57:23 2011
+++ doc/posix-functions/setkey.texi     Thu Sep  8 11:56:28 2011
@@ -15,4 +15,8 @@
 @item
 This function is missing on some platforms:
 NetBSD 5.0, Minix 3.1.8, Cygwin, mingw, BeOS.
address@hidden
+This function is not declared in @code{<stdlib.h>}
+(without @code{-D_GNU_SOURCE}) on some platforms:
+glibc 2.11.
 @end itemize
-- 
In memoriam Elisabeth von Thadden 
<http://en.wikipedia.org/wiki/Elisabeth_von_Thadden>