bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: strsignal on MSVC


From: Eric Blake
Subject: Re: strsignal on MSVC
Date: Mon, 03 Oct 2011 17:28:08 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.22) Gecko/20110906 Fedora/3.1.14-1.fc14 Lightning/1.0b3pre Mnenhy/0.8.4 Thunderbird/3.1.14

On 10/03/2011 05:23 PM, Bruno Haible wrote:
On MSVC 9, strsignal.c gets many compilation errors,
because glthread/lock.h includes<windows.h>, which includes<winsock.h>,
and<unistd.h>  includes<winsock2.h>. The two socket headers collide.

Also, it can get a compilation error because it uses<unistd.h>  without
depending on the 'unistd' module.

Shouldn't the fix for this to be adding a module dependency in modules/strsignal, rather than...

        * lib/strsignal.c: Include<string.h>  first. Don't include<unistd.h>
        if HAVE_UNISTD_H is false.

reverting to the use of HAVE_UNISTD_H in a .c file?

--
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]