bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] GNUmakefile: reenable "make syntax-check" for most projects


From: Gary V. Vaughan
Subject: Re: [PATCH] GNUmakefile: reenable "make syntax-check" for most projects
Date: Mon, 31 Oct 2011 09:45:35 +0700

Hi Jim,

On 31 Oct 2011, at 04:25, Jim Meyering wrote:
> FYI, I've just pushed the following fix.
> 
> I share blame, as the reviewer.
> I did not test Friday's change until today.
> 
> Since Friday's commit 05e2d798, "maint.mk: don't maintain a second
> build-aux variable", "syntax-check" would do nothing but succeed with
> the "No version control files detected..." diagnostic (unless you
> happened to override _build-aux via cfg.mk).
> * top/GNUmakefile (_autoreconf, _build-aux): Move default definitions
> to precede inclusion of maint.mk.  Otherwise, these variables would
> be used undefined in any project that does not override the default.

Oh, ouch.  Sorry about that.  I should have tested without a cfg.mk
override before submitting, but didn't think to look because it was
working fine in my tree without the patch.  My bad.

Cheers,
-- 
Gary V. Vaughan (gary AT gnu DOT org)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]