bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] gitlog-to-changelog: fix git-log invocation


From: Dmitry V. Levin
Subject: [PATCH] gitlog-to-changelog: fix git-log invocation
Date: Mon, 31 Oct 2011 19:56:52 +0400

git-log mishandles date strings before 1970-01-01 UTC, and there is
no use to specify --since=1970-01-01 by default anyway.
* build-aux/gitlog-to-changelog: By default, when no --since option
was given, do not specify explicit --since option to git-log.
---
 ChangeLog                     |    8 ++++++++
 build-aux/gitlog-to-changelog |    9 +++++++--
 2 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 76d1c64..beae627 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2011-10-31  Dmitry V. Levin  <address@hidden>
+
+       gitlog-to-changelog: fix git-log invocation.
+       git-log mishandles date strings before 1970-01-01 UTC, and there is
+       no use to specify --since=1970-01-01 by default anyway.
+       * build-aux/gitlog-to-changelog: By default, when no --since option
+       was given, do not specify explicit --since option to git-log.
+
 2011-10-30  Dmitry V. Levin  <address@hidden>
 
        gitlog-to-changelog: new option --append-dot.
diff --git a/build-aux/gitlog-to-changelog b/build-aux/gitlog-to-changelog
index 1a9d500..3893197 100755
--- a/build-aux/gitlog-to-changelog
+++ b/build-aux/gitlog-to-changelog
@@ -102,7 +102,7 @@ sub quoted_cmd(@)
 }
 
 {
-  my $since_date = '1970-01-01 UTC';
+  my $since_date = '';
   my $format_string = '%s%n%b%n';
   my $append_dot = 0;
   GetOptions
@@ -114,7 +114,12 @@ sub quoted_cmd(@)
      'append-dot' => \$append_dot,
     ) or usage 1;
 
-  my @cmd = (qw (git log --log-size), "--since=$since_date",
+  if ($since_date)
+    {
+      unshift(@ARGV, "--since=$since_date");
+    }
+
+  my @cmd = (qw (git log --log-size),
              '--pretty=format:%ct  %an  <%ae>%n%n'.$format_string, @ARGV);
   open PIPE, '-|', @cmd
     or die ("$ME: failed to run `". quoted_cmd (@cmd) ."': $!\n"
-- 
1.7.6



reply via email to

[Prev in Thread] Current Thread [Next in Thread]