bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: split off module mkdirat from module openat


From: Paul Eggert
Subject: Re: split off module mkdirat from module openat
Date: Fri, 04 Nov 2011 11:25:04 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0

On 11/04/11 03:54, Bruno Haible wrote:
>   - openat uses lib/at-func.c, which includes <dirent.h>, thus requires module
>     'dirent'.

Thanks for all that work.  This particular change prompted me to look
into why at-func.c includes dirent.h via openat.h, and this inclusion
appears to be no longer needed, so I pushed this:

openat: remove direct dependency on dirent
* lib/openat.h: Don't include <dirent.h>; it's no longer needed,
and hasn't been needed ever since fdopendir was split into its own
module on 2009-08-31.
* modules/openat (Depends-on): Remove dirent.
diff --git a/lib/openat.h b/lib/openat.h
index 03a513d..eae86ce 100644
--- a/lib/openat.h
+++ b/lib/openat.h
@@ -23,7 +23,6 @@

 #include <sys/types.h>
 #include <sys/stat.h>
-#include <dirent.h>
 #include <unistd.h>
 #include <stdbool.h>

diff --git a/modules/openat b/modules/openat
index 18544f0..c051e71 100644
--- a/modules/openat
+++ b/modules/openat
@@ -11,7 +11,6 @@ m4/openat.m4
 m4/mode_t.m4

 Depends-on:
-dirent
 dosname
 errno
 extensions



reply via email to

[Prev in Thread] Current Thread [Next in Thread]