bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: openat includes


From: Paul Eggert
Subject: Re: openat includes
Date: Sat, 05 Nov 2011 01:53:09 -0700
User-agent: Mozilla/5.0 (X11; Linux i686; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1

On 11/05/11 01:46, Bruno Haible wrote:
> lib/openat.c uses 'bool' and relies on openat.h for <stdbool.h>. This is a
> pitfall for future refactorings

I dunno, this sounds like overkill to me.

Any refactoring that would modify openat.h so much that
it would remove bool, would cause openat.h to no longer
specify openat_needs_fchdir -- which is a function that
openat.c must implement.  The chance that 'bool' would
be a pitfall without 'openat_needs_fchdir' being a larger
pitfall is essentially zero.

In general in my experience it's OK for foo.c to assume
interfaces provided by foo.h.  They're typically maintained
together and refactored together anyway.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]