Re: git-version-gen

[Jim Meyering]

Eric Blake wrote:
> On 11/12/2011 11:53 AM, Simon Josefsson wrote:
>> For inetutils (which uses git tags looking like 'inetutils-1_8') we
>> noticed that git-version-gen hardcodes an expression when searching for
>> particular tags:
>>
>>     && v=`git describe --abbrev=4 --match='v*' HEAD 2>/dev/null \
>>
>> I guess there are at least two questions:
>>
>> 1) Is it really required?
>
> What did you mean by "it"?  The use of "--match=pattern"?  Yes, since
> that allows you the freedom to have more tags than just official
> releases.  (I frequently have local tags to intermediate points, but
> only push official v1.0 style tags upstream, but since the command runs
> locally, git describe tries to use my local tags unless I use --match).
>
>>
>> 2) Any reason against making the expression 'v*' configurable?
>
> No problem by me - I'd welcome a patch that adds a --label-pattern
> option that defaults to 'v*' but can be overridden by a cfg.mk variable.

Same here.  Patch welcome.