bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: openat requires lstat.m4


From: Bruno Haible
Subject: Re: openat requires lstat.m4
Date: Wed, 16 Nov 2011 03:12:06 +0100
User-agent: KMail/1.13.6 (Linux/2.6.37.6-0.5-desktop; KDE/4.6.0; x86_64; ; )

Hi,

Ben Walton wrote:
> I was playing with some gnulib stuff tonight and noticed that if I
> import only openat, I get errors when later running autoreconf:
> 
> configure.ac:17: warning: gl_FUNC_LSTAT_FOLLOWS_SLASHED_SYMLINK is 
> m4_require'd but not m4_defun'd
> m4/openat.m4:11: gl_FUNC_OPENAT is expanded from...
> m4/gnulib-comp.m4:105: gl_INIT is expanded from...
> configure.ac:17: the top level
> 
> The following small tweak resolved this for me but I don't know if
> this is a complete or proper fix.
> 
> diff --git a/modules/openat b/modules/openat
> index f2da9bc..4124541 100644
> --- a/modules/openat
> +++ b/modules/openat
> @@ -5,6 +5,7 @@ Files:
>  lib/at-func.c
>  lib/openat.c
>  lib/openat-priv.h
> +m4/lstat.m4
>  m4/openat.m4
>  m4/mode_t.m4

The fix is correct. For maintainability it needs to be added also to
some other module descriptions.

I'm applying this. The "tiny change" is not meant to be a derogatory
designation; it merely documents that your contribution to gnulib so far
did not require the exchange of copyright assignment paperwork.


2011-11-15  Ben Walton <address@hidden>  (tiny change)
            Bruno Haible  <address@hidden>

        Fix some modules' file list.
        * modules/fstatat (Files): Add m4/lstat.m4.
        * modules/openat (Files): Likewise.
        * modules/unlinkat (Files): Likewise.

--- modules/fstatat.orig        Wed Nov 16 03:06:12 2011
+++ modules/fstatat     Wed Nov 16 03:05:07 2011
@@ -6,6 +6,7 @@
 lib/at-func.c
 lib/openat-priv.h
 m4/fstatat.m4
+m4/lstat.m4
 
 Depends-on:
 sys_stat
--- modules/openat.orig Wed Nov 16 03:06:12 2011
+++ modules/openat      Wed Nov 16 03:05:06 2011
@@ -6,6 +6,7 @@
 lib/openat.c
 lib/openat-priv.h
 m4/openat.m4
+m4/lstat.m4
 m4/mode_t.m4
 
 Depends-on:
--- modules/unlinkat.orig       Wed Nov 16 03:06:12 2011
+++ modules/unlinkat    Wed Nov 16 03:05:06 2011
@@ -6,6 +6,7 @@
 lib/at-func.c
 lib/openat-priv.h
 m4/unlinkat.m4
+m4/lstat.m4
 
 Depends-on:
 unistd

-- 
In memoriam Kurt Gerron <http://en.wikipedia.org/wiki/Kurt_Gerron>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]