bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: libgnu: rpl_getcwd broken on OpenBSD 4.6


From: Kai Habel
Subject: Re: libgnu: rpl_getcwd broken on OpenBSD 4.6
Date: Sat, 19 Nov 2011 13:01:59 +0100
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0) Gecko/20111105 Thunderbird/8.0

Am 19.11.2011 03:07, schrieb Paul Eggert:
Thanks for the further details about the problem.

On 11/18/11 14:54, Mats Erik Andersson wrote:
# if ! HAVE_WORKING_FSTATAT_ZERO_FLAG
#  define AT_FUNC_NAME rpl_fstatat
# else
#  define AT_FUNC_NAME fstatat
# endif

... This is probably broken.
Right you are.  The macro should depend on HAVE_FSTATAT,
not on HAVE_WORKING_FSTATAT_ZERO_FLAG.

Conclusion: The computation of REPLACE_FSTATAT is broken.
Hmm, no, I think that part is OK.  REPLACE_FSTATAT does not mean
"please supply a fstatat implementation from gnulib's".  It means "please
replace the system's fstatat implementation with gnulib's", which is
less common.

Anyway, I've verified that the following patch fixes the bug on
Solaris 8, so I've pushed it into gnulib.

Can you please try it for OpenBSD 4?  Thanks.  I'll also
CC: this to Kai Habel, as I think it'll fix his problem too.
[...]
Indeed with the previous patch (about fdopendir) and this one I am able to compile gnulib again. Thanks!

Kai




reply via email to

[Prev in Thread] Current Thread [Next in Thread]