Re: manywarnings update

[Jim Meyering]

Simon Josefsson wrote:

> I have pushed the patch below.  For Libtasn1, the only new warning flag
> I had to manually disable for that project was -Wsuggest-attribute=pure
> because there were many hits and I didn't feel like adding many function
> attributes.  Unfortunately, several of the parameters aren't documented
> in the manual so it is unclear whether they are implied by -Wall or not.
>
> /Simon
>
>>From 3e07d5d60bee7d0e6fc0d79e974ce5a8dc7dea61 Mon Sep 17 00:00:00 2001
> From: Simon Josefsson <address@hidden>
> Date: Sun, 20 Nov 2011 23:08:31 +0100
> Subject: [PATCH] manywarnings: More warnings.
>
> * m4/manywarnings.m4: Add more warnings from gcc 4.6.2.
> ---
>  ChangeLog          |    4 ++++
>  m4/manywarnings.m4 |   27 +++++++++++++++++++++++++++
>  2 files changed, 31 insertions(+), 0 deletions(-)
>
> diff --git a/ChangeLog b/ChangeLog
> index e447786..8173a2e 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,7 @@
> +2011-11-20  Simon Josefsson  <address@hidden>
> +
> +     * m4/manywarnings.m4: Add more warnings from gcc 4.6.2.
> +

Thanks.
I took that for a spin in coreutils (not yet pushed, of course).
Lots of new "error"s, doubtless soon to be dealt with or ignored:

168 format not a string literal, argument types not checked 
[-Werror=format-nonliteral]
135 unsuffixed float constant [-Werror=unsuffixed-float-constants]
  4 format not a string literal, format string not checked 
[-Werror=format-nonliteral]
  1 implicit conversion from 'float' to 'double' when passing argument to 
function [-Werror=double-promotion]