Re: [PATCH] tests: add a syntax check for last week's global change

[Eric Blake]

On 11/28/2011 12:18 PM, Jim Meyering wrote:
>> That is, any objections to moving this out of coreutil's cfg.mk and into
>> gnulib's maint.mk?
> 
> I was reluctant to do that because "compare" is a pretty common word,
> and I didn't try to limit the rule to a particular (tests/) directory.
> If it works in libvirt with no false positives, that is a pretty good
> indication that we don't need to worry about them just yet.

Ah, but $(_sc_search_regexp) already supports the notion of
containing=... as a way of filtering to just files that contain
'init.sh', and thus limiting things to files that actually use compare()
from init.sh.

> 
> If it comes to that, we could limit the rule to packages that have
> gnulib's init.sh.

Yep, I plan on doing that as part of the move.

> 
> So, yes, this is fine with me.
> Welcome actually, so we'll benefit also via grep, diffutils, parted,
> etc., without having to add to their local cfg.mk files.
> 
> Thanks.
> 
> You're welcome to remove it from coreutils' cfg.mk, too.

Okay, I'm now in the middle of coding up the move, and will post and
push the patches if results look reasonable with libvirt.

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature