bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: #define FOO rpl_FOO in config.h


From: Eric Blake
Subject: Re: #define FOO rpl_FOO in config.h
Date: Tue, 29 Nov 2011 08:45:46 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0

On 11/29/2011 01:01 AM, John W. Eaton wrote:
> While trying to cross compile Octave for MinGW, I hit the following
> errors:
> 
>   In file included from /home/jwe/src/octave/liboctave/oct-time.h:26:0,
>                    from /home/jwe/src/octave/liboctave/file-stat.h:28,
>                    from /home/jwe/src/octave/liboctave/file-ops.cc:43:
>   /usr/include/c++/4.6/ctime:72:11: error: '::gmtime' has not been declared
>   /usr/include/c++/4.6/ctime:73:11: error: '::localtime' has not been declared
> 
> 
> Would it be possible to handle these definitions in gnulib's time.h
> instead of inserting them in config.h?

Yes, we need to modernize this module to get rid of the in-config.h
replacements, like we have done for other modules.  Would you like to
try helping in that process?  See commit 60b73b05 for an example of
where we did the same for mktime().

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]